Skip to content

kdf: add HKDF support - #173

Merged
rhenium merged 1 commit into
ruby:masterfrom
rhenium:ky/kdf-hkdf
Nov 25, 2017
Merged

rhenium merged 1 commit into
ruby:masterfrom
rhenium:ky/kdf-hkdf

Conversation

@rhenium

@rhenium rhenium commented Nov 22, 2017

Copy link
Copy Markdown
Member

OpenSSL 1.1.0 supports HKDF through the EVP API. Add OpenSSL::KDF.hkdf
as a wrapper around that.

Closes #172 if merged.

OpenSSL 1.1.0 supports HKDF through the EVP API. Add OpenSSL::KDF.hkdf
as a wrapper around that.

Reference: ruby#172
@rhenium rhenium mentioned this pull request Nov 22, 2017
@bdewater

bdewater commented Nov 22, 2017 •

Copy link
Copy Markdown
Contributor

Thanks for working on this so quickly! I'll try and build this branch locally to see if it works for the Android Pay/Pay with Google decryption use case I mentioned in the issue.

bdewater added a commit to bdewater/r2d2 that referenced this pull request Nov 24, 2017
@bdewater

bdewater commented Nov 24, 2017 •

Copy link
Copy Markdown
Contributor

Verified my test suite still passes when I change the HKDF implementation. Quick benchmarking shows that it's ~2.1 times faster than the Ruby-based implementation. Thanks again!

@rhenium
rhenium merged commit 4e53940 into ruby:master Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants